| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Oleg Bartunov <oleg(at)sai(dot)msu(dot)su> |
| Cc: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: [HACKERS] 6.5.1 |
| Date: | 1999-07-10 22:16:01 |
| Message-ID: | 10704.931644961@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> And, right offhand, I'm not seeing where <time.h> gets included before
> heapam.h is read.
I dug into this and found that on my own machine, <sys/time.h> is pulled
in by <arpa/inet.h> which is pulled in by config.h (if the right
configuration symbols are defined). It looks to me like there is
noplace that explicitly pulls in <time.h> before heapam.h is read.
In short, what we've got here is code that only works because of
interdependencies among system headers. Not too portable.
I added "#include <time.h>" to heapam.h, which I think will fix Oleg's
problem, but I'm a little bit mystified why we didn't find this long
ago. Someone must have removed an #include somewhere that covered up
the problem...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | pgsql-hackers | 1999-07-11 01:32:13 | |
| Previous Message | Tom Lane | 1999-07-10 21:51:00 | Re: [HACKERS] 6.5.1 |