From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [HACKERS] 6.5.1 |
Date: | 1999-07-11 01:59:41 |
Message-ID: | 199907110159.VAA07502@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
One thing I want to do for 6.6 is make sure each include file has the
proper includes to compile just itself, and try to remove extra
non-system includes in the C files.
> I wrote:
> > And, right offhand, I'm not seeing where <time.h> gets included before
> > heapam.h is read.
>
> I dug into this and found that on my own machine, <sys/time.h> is pulled
> in by <arpa/inet.h> which is pulled in by config.h (if the right
> configuration symbols are defined). It looks to me like there is
> noplace that explicitly pulls in <time.h> before heapam.h is read.
>
> In short, what we've got here is code that only works because of
> interdependencies among system headers. Not too portable.
>
> I added "#include <time.h>" to heapam.h, which I think will fix Oleg's
> problem, but I'm a little bit mystified why we didn't find this long
> ago. Someone must have removed an #include somewhere that covered up
> the problem...
>
> regards, tom lane
>
>
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 1999-07-11 02:00:36 | 6.5.1 CHANGES |
Previous Message | pgsql-hackers | 1999-07-11 01:32:13 |