| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Error code for checksum failure in origin.c |
| Date: | 2021-08-26 10:41:32 |
| Message-ID: | 03D55F32-C84F-44D6-9E64-F34408AF91AA@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 26 Aug 2021, at 12:03, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Aug 26, 2021 at 3:18 PM Kasahara Tatsuhito
> <kasahara(dot)tatsuhito(at)gmail(dot)com> wrote:
>>
>> Hi.
>>
>> In the code in src/backend/replication/logical/origin.c,
>> the error code "ERRCODE_CONFIGURATION_LIMIT_EXCEEDED" is given
>> when a checksum check results in an error,
>> but "ERRCODE_ DATA_CORRUPTED" seems to be more appropriate.
>>
>
> +1. Your observation looks correct to me and the error code suggested
> by you seems appropriate. We use ERRCODE_DATA_CORRUPTED in
> ReadTwoPhaseFile() for similar error.
Agreed, +1 for changing this.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2021-08-26 10:58:40 | Re: Failure of subscription tests with topminnow |
| Previous Message | Peter Smith | 2021-08-26 10:11:06 | Re: row filtering for logical replication |