Re: Error code for checksum failure in origin.c

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Error code for checksum failure in origin.c
Date: 2021-08-26 10:03:52
Message-ID: CAA4eK1Jt2hzNv=bMH8v8q34ed4pxWgPhtvX4f-CGncbV-Yj_OA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 26, 2021 at 3:18 PM Kasahara Tatsuhito
<kasahara(dot)tatsuhito(at)gmail(dot)com> wrote:
>
> Hi.
>
> In the code in src/backend/replication/logical/origin.c,
> the error code "ERRCODE_CONFIGURATION_LIMIT_EXCEEDED" is given
> when a checksum check results in an error,
> but "ERRCODE_ DATA_CORRUPTED" seems to be more appropriate.
>

+1. Your observation looks correct to me and the error code suggested
by you seems appropriate. We use ERRCODE_DATA_CORRUPTED in
ReadTwoPhaseFile() for similar error.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2021-08-26 10:11:06 Re: row filtering for logical replication
Previous Message Peter Eisentraut 2021-08-26 10:03:48 verify_heapam for sequences?