Re: Fixes and enhancements to JDBC driver (take 2)

From: Gunnar R|nning <gunnar(at)candleweb(dot)no>
To: Richard Bullington-McGuire <rbulling(at)microstate(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Fixes and enhancements to JDBC driver (take 2)
Date: 2001-01-18 13:49:23
Message-ID: x6bst5dl7g.fsf@thor.candleweb.no
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-interfaces pgsql-patches

Richard Bullington-McGuire <rbulling(at)microstate(dot)com> writes:

> * A serious off-by-one error existed in both of the BytePoolDim classes in
> the org.postgresql.PG_Stream class. On a request for a byte pool for the
> maximum size, the old code would generate an
> ArrayIndexOutOfBoundsException. I fixed this by increasing the size of
> the array by one more than the maximum buffer size, and altering the
> supporting methods to initialize and clean up the expanded array.

This BytePoolDim code got other problems as well. I posted another
implementation of the same pooling idea back in October, but it never got
in to replace the current buggy code. As I wrote in pgsql-general earlier
today, I will look into creating a new patch with another pooling
implementation that should work a lot better.

regards,

Gunnar

In response to

Responses

Browse pgsql-interfaces by date

  From Date Subject
Next Message The Hermit Hacker 2001-01-18 13:53:14 Re: [RFC] Proposed split of -interfaces list ...
Previous Message Adam Lang 2001-01-18 13:44:09 Re: Where is new pgsql ODBC driver ?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-01-18 18:56:39 your JDBC patch
Previous Message Richard Bullington-McGuire 2001-01-17 23:30:59 Re: Patch for JDBC timestamp problems