| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru> |
| Cc: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: shared-memory based stats collector - v70 |
| Date: | 2024-12-03 15:07:07 |
| Message-ID: | wurgoxcnwm44fdysbgkyucjedwp4jxqjzpw2mk2meqjnhdmlao@fldawjm5fmp2 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2024-12-03 13:37:48 +0300, Anton A. Melnikov wrote:
> Found a place in the code of this patch that is unclear to me:
> https://github.com/postgres/postgres/blob/1acf10549e64c6a52ced570d712fcba1a2f5d1ec/src/backend/utils/activity/pgstat.c#L1658
>
> Owing assert() the next if() should never be performed, but the comment above says the opposite.
> Is this assert really needed here? And if so, for what?
It's code that should be unreachable. But in case it is encountered in a
production scenario, it's not worth taking down the server for it.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-12-03 15:37:41 | Re: code contributions for 2024, WIP version |
| Previous Message | Kirill Reshke | 2024-12-03 15:04:08 | Re: Amcheck verification of GiST and GIN |