| From: | "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: shared-memory based stats collector - v70 |
| Date: | 2024-12-04 01:00:53 |
| Message-ID: | b1dbea9a-f433-4dd7-85cd-d706cfdc67fa@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03.12.2024 18:07, Andres Freund wrote:
> Hi,
>
> On 2024-12-03 13:37:48 +0300, Anton A. Melnikov wrote:
>> Found a place in the code of this patch that is unclear to me:
>> https://github.com/postgres/postgres/blob/1acf10549e64c6a52ced570d712fcba1a2f5d1ec/src/backend/utils/activity/pgstat.c#L1658
>>
>> Owing assert() the next if() should never be performed, but the comment above says the opposite.
>> Is this assert really needed here? And if so, for what?
>
> It's code that should be unreachable. But in case it is encountered in a
> production scenario, it's not worth taking down the server for it.
Thanks! It's clear.
Although there is a test case that lead to this assertion to be triggered.
But i doubt if anything needs to be fixed.
I described this case in as it seems to me suitable thread:
https://www.postgresql.org/message-id/56bf8ff9-dd8c-47b2-872a-748ede82af99%40postgrespro.ru
Would be appreciate if you take a look on it.
With the best wishes,
--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-12-04 01:20:19 | Re: Remove remnants of "snapshot too old" |
| Previous Message | Michael Paquier | 2024-12-04 00:55:16 | Re: Memory leak in WAL sender with pgoutput (v10~) |