pgadmin4 setup.py, first time run

From: Prasad <prasad(dot)s(at)mail(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: pgadmin4 setup.py, first time run
Date: 2015-09-05 23:42:37
Message-ID: trinity-dc01e743-5753-487f-b9b0-22525f6ce3de-1441496556982@3capp-mailcom-lxa14
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

When you try to run pgadmin4 for first time(without presence of pgadmin4.db), it ask you to run setup.py. When you run it, it throws python error as follows,
Traceback (most recent call last):
File "/home/test/Development/pgadmin4/web/setup.py", line 145, in <module>
do_setup(app)
File "/home/test/Development/pgadmin4/web/setup.py", line 57, in do_setup
user_datastore.add_role_to_user(email, 'Administrators')
File "/usr/local/lib/python2.7/dist-packages/Flask_Security-1.7.4-py2.7.egg/flask_security/datastore.py", line 106, in add_role_to_user
if role not in user.roles:
AttributeError: 'NoneType' object has no attribute 'roles'

It's because,user_datastore.create_role,user_datastore.create_user and user_datastore.add_role_to_user all calls are for in one database transaction. It need to commit it after first two calls or creating role and user for add_role_to_user to work,

Find attached patch for this.

regards,
Prasad Somwanshi

Attachment Content-Type Size
AddRoleToUser.patch text/x-patch 503 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2015-09-07 08:01:20 Re: pgadmin4 setup.py, first time run
Previous Message Dave Page 2015-09-03 07:25:11 Re: PATCH: improve sorting in the Data Editor