Re: PATCH: improve sorting in the Data Editor

Hi

On Wed, Sep 2, 2015 at 6:31 AM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:

>
> Hi, Dave!
>
>
> I see bugreports and patches for PgAdmin III are set aside.
>
Not set aside - it's just that the people on my team are busy with other
work at the moment. There are other committers though.

> What's the current state of the project?
>
> If it isn't going to develop further - that should be told to community.
>
pgAdmin III will be around for at least another year, but EDB staff are
concentrating mostly on pgAdmin 4 at the moment. That's been the subject of
blogs and talks at various conferences, and you should have seem commits
and some discussion here I expect.

>
> Seeing one's efforts being ignored simply kills enthusiasm :(
>
>
>
> Wednesday, August 12, 2015, 7:06:04 PM, J.F. Oster wrote:
>
>
> >
>
>
> Ashesh, will you commit this, please?
>
>
>
> Thursday, August 6, 2015, 12:16:37 PM, you wrote:
>
>
> >
>
> Hi,
>
>
> In this case patch looks good to me.
>
>
>
> Regards,
>
> Sanket Mehta
>
> Sr Software engineer
>
> Enterprisedb
>
>
>
> On Thu, Aug 6, 2015 at 2:22 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
>
>
>
>
> On Wed, Aug 5, 2015 at 6:20 PM, Sanket Mehta <
> sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
>
>
> Hi,
>
>
> I have reviewed the patch and below is analysis.
>
>
> - Behaviour of sorting in data editor before applying the patch is as
> below:
>
>
> By default table is sorted by PK/OID in ascending order.
>
> when user select any other column to sort the table, that column gets the
> second priority for sorting the table like i.e.order by col_pk, col_column1
> where col_pk is column having PK and col_column1 is any other ordinary
> column.
>
>
> - below is the behaviour I have found after applying the patch:
>
>
> By default table is sorted by PK/OID in ascending order.
>
> When user selects any other column default sorting is removed and table is
> getting sorted by newly selected column.
>
> But after this if user wants to sort the table by PK or any other column
> it will have the same behaviour like it has before applying the patch. i.e.
> order by col_column1, col_PK where col_column1 and col_PK are same as
> explained above. It will not sort the table by newly selected
> column(col_PK) because sorting of older column(col_column1) is still in
> effect and has the higher priority.
>
>
> This will also confuse the user.
>
>
> So according to me current behaviour of sorting of table data in pgadmin
> is acceptable.
>
>
> Dave,
>
> Do you have any other thoughts on it?
>
>
> I think J.F's patch makes sense. It is a little more complex logically
> speaking, but I also think it's more likely what the user would expect to
> happen.
>
>
>
>
>
>
> Regards,
>
> Sanket Mehta
>
> Sr Software engineer
>
> Enterprisedb
>
>
>
> On Mon, Aug 3, 2015 at 11:07 AM, Sanket Mehta <
> sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
>
>
> Sure Ashesh.
>
>
>
> Regards,
>
> Sanket Mehta
>
> Sr Software engineer
>
> Enterprisedb
>
>
>
> On Mon, Aug 3, 2015 at 10:49 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>
> Sanket,
>
>
> Can you please review it?
>
>
>
>
> --
>
> Thanks & Regards,
>
>
> Ashesh Vashi
>
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> http://www.linkedin.com/in/asheshvashi
>
>
>
> On Sun, Aug 2, 2015 at 3:49 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
>
> Hello,
>
>
> Here is a small improvement about sorting in the Data editor.
>
>
> Problem:
>
> If a table has a PK or OIDs, it gets sorted by PK/OID by default.
>
> When a user wants to sort by any other column, he has first to click
>
> "Remove sort" in the context menu, and only then click "Sort
>
> ascending"(descending) on column of his choice.
>
>
> If he doesn't remove the default sort, he will get no effect and
>
> probably be puzzled for the first time until guesses that he makes
>
> ORDER BY column_pk, column_of_choice
>
> which is totally useless.
>
> The need to "Remove sort" each time is annoying.
>
>
> Solution:
>
> When a user chooses to sort by some column, we must discard the
>
> default sort order.
>
>
> Please see the attached patch.
>
> Thanks.
>
>
> --
>
> Best regards,
>
> J.F.
>
>
> --
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>
> To make changes to your subscription:
>
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
>
>
>
>
> --
>
>
> Dave Page
>
> Blog: http://pgsnake.blogspot.com
>
> Twitter: @pgsnake
>
>
> EnterpriseDB UK: http://www.enterprisedb.com
>
> The Enterprise PostgreSQL Company
>
>
>
>
>
> --
>
> Best regards,
>
> J.F.
>
>
>
>
>
> --
>
> Best regards,
>
> J.F.
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company