Re:Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function?

From: zxwsbg <zxwsbg(at)qq(dot)com>
To: pgsql-general <pgsql-general(at)postgresql(dot)org>
Subject: Re:Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function?
Date: 2022-11-24 08:03:37
Message-ID: tencent_DD447707A5E37A1D6B1A428FCE4C1057EB06@qq.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

I don't know what happened, but an image seems to be better.
------------------&nbsp;Original&nbsp;------------------
From: "zxwsbg" <zxwsbg(at)qq(dot)com&gt;;
Date:&nbsp;Thu, Nov 24, 2022 04:01 PM
To:&nbsp;"pgsql-general"<pgsql-general(at)postgresql(dot)org&gt;;

Subject:&nbsp;Why not set builder-&gt;next_phase_at=InvalidTransactionId in SnapBuildRestore function?

Last email has some problem, I resend one.

In PG14 or higher version, I notice that SnapBuildRestore function don't set builder-&gt;next_phase_at=InvalidTransactionId .

But in SnapBuildSerialize function, the assert check this condition.

Assert(builder-&gt;next_phase_at == InvalidTransactionId);

I'd like to know is this right?

Thanks.

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Ryo Yamaji (Fujitsu) 2022-11-24 10:06:54 About row locking ordering
Previous Message zxwsbg 2022-11-24 08:01:52 Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function?