| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Rahila Syed <rahilasyed90(at)gmail(dot)com> |
| Subject: | Re: Add missing PGDLLIMPORT markings |
| Date: | 2025-04-09 15:27:58 |
| Message-ID: | kuei22liq3mptassdfmtdd7dn2yc6a26hngvxe7kj5kgf2j4sw@wvsb3su6xs22 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2025-04-09 12:02:52 +0200, Peter Eisentraut wrote:
> I ran src/tools/mark_pgdllimport.pl and it detected a few new global
> variables with missing markings. See attached patch. Please point out if
> any of these should not be marked or if they are special cases in some other
> way. I'm Cc'ing various people involved with that new code.
FWIW, the AIO ones really don't make sense to make public - the only reason
for those variables to exists is so they can be put into an array of
callbacks. There's no way an extension could ever benefit from them. But I
guess we don't really have a way to tell mark_pgdllimport.pl that.
I did mark the internal AIO variables that maybe kinda somewhat insanely used
by an extension as PGDLLIMPORT (c.f. aio_internal.h)...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-04-09 15:28:31 | Re: Draft for basic NUMA observability |
| Previous Message | Maksim.Melnikov | 2025-04-09 15:21:50 | Re: sync_standbys_defined read/write race on startup |