| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Rahila Syed <rahilasyed90(at)gmail(dot)com> |
| Subject: | Re: Add missing PGDLLIMPORT markings |
| Date: | 2025-04-09 16:58:23 |
| Message-ID: | CA+TgmoZCDVK4hk+XB6Qv67xsnCVxTy9frwb8a5CLLw-8eOVXEA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 9, 2025 at 11:28 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> FWIW, the AIO ones really don't make sense to make public - the only reason
> for those variables to exists is so they can be put into an array of
> callbacks. There's no way an extension could ever benefit from them. But I
> guess we don't really have a way to tell mark_pgdllimport.pl that.
I'm not here to say that you're wrong, but this kind of argument is
exactly why we didn't use to mark a bunch of things PGDLLIMPORT that,
as it turned out, extension developers actually wanted to use.
I don't think we should go back to the bad old days where we litigated
every case of marking something PGDLLIMPORT or not unless we have an
extremely good reason for so doing.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-04-09 17:04:21 | Re: Horribly slow pg_upgrade performance with many Large Objects |
| Previous Message | Sami Imseih | 2025-04-09 16:57:10 | n_ins_since_vacuum stats for aborted transactions |