Re: Include patch id in commitfest page

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Jelte Fennema-Nio <github-tech(at)jeltef(dot)nl>, Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Include patch id in commitfest page
Date: 2025-01-11 09:40:26
Message-ID: ff9d7921-f4e3-498a-9dba-ddd28fdb359f@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I want to register that I'm not a fan of this change:

https://git.postgresql.org/gitweb/?p=pgcommitfest2.git;a=commit;h=eee60a5332ac0745071086477ff4e189b080d3ab

Rationale: It puts the least important information first. For the most
part, the CF entry number is irrelevant, so it shouldn't be shown in
such a prominent position.

Maybe

<a>title here</a> (number here)

would be a compromise. But looking at the original argument:

"""
Clicking the patch header would sort by the patch ID, but that ID would
not actually be visible. Effectively resulting in random ordering for
the user, so let's just show the ID.
"""

I would suggest that the actual fix would be to order by title instead
of ID.

Or just turn the sorting off.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2025-01-11 09:53:52 Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
Previous Message yuansong 2025-01-11 09:40:01 Re:Re: Re:Re:Re: backup server core when redo btree_xlog_insert that type is XLOG_BTREE_INSERT_POST