Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
Date: 2025-01-11 09:53:52
Message-ID: CALdSSPhxprTyzzr4tk-QU-GUroBKYNuJJ2GxWnExbB=bjQjJ7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 10 Jan 2025 at 11:38, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> I think there are three remaining issues that may need more attention
> 1.
> Table 27.42. pg_stat_progress_copy View
> (<structname>pg_stat_progress_copy</structname>)
> column pg_stat_progress_copy.tuples_skipped now the description is
> ""
> When the ON_ERROR option is set to ignore, this value shows the number of tuples
> skipped due to malformed data. When the ON_ERROR option is set to set_to_null,
> this value shows the number of tuples where malformed data was converted to
> NULL.
> """
> now the column name tuples_skipped would not be that suitable for
> (on_error set_to_null).
> since now it is not tuple skipped, it is in a tuple some value was set to null.

Indeed this is something we need to fix.

> Or
> we can skip progress reports for (on_error set_to_null) case.

Maybe we can add a `malformed_tuples` column to this view?

> 3. do we settled (on_error set_to_null) syntax.

I think so. I prefer this syntax to others discussed in this thread.

--
Best regards,
Kirill Reshke

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2025-01-11 10:29:57 Re: improve DEBUG1 logging of parallel workers for CREATE INDEX?
Previous Message Peter Eisentraut 2025-01-11 09:40:26 Re: Include patch id in commitfest page