injection points for hash aggregation

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: injection points for hash aggregation
Date: 2025-02-03 20:45:24
Message-ID: ff4e59305e5d689e03cd256a736348d3e7958f8f.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Attached is a patch that adds a few injection points for hash
aggregation.

A couple questions on the injection points framework:

* The patch allows forcing the partition fan-out to one. I could
imagine forcing it to a specific value, is there a way to do that?

* The injection_points extension offers the concept of a "local"
injection point. While that makes sense for the callback function, it
doesn't make sense when using the "local_var = 123" style, because that
will happen regardless of the condition, right?

* Callbacks are given very little context from the injection point
itself, so it's hard for me to imagine what a callback might do other
than logging the name of the injection point or waiting (as the
extension implements). What else would callbacks be good for?

--
Jeff Davis
PostgreSQL Contributor Team - AWS

Attachment Content-Type Size
v1-0001-Add-injection-points-for-hash-aggregation.patch text/x-patch 8.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-02-03 20:48:34 Re: Prevent COPY FREEZE on Foreign tables
Previous Message David E. Wheeler 2025-02-03 20:42:43 Re: RFC: Additional Directory for Extensions