| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Prevent COPY FREEZE on Foreign tables |
| Date: | 2025-02-03 20:48:34 |
| Message-ID: | Z6ErokJ7favVX-Oh@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 03, 2025 at 02:18:21PM -0600, Sami Imseih wrote:
> I think we should just block Foreign tables as we do with
> partition tables. Attached patch does that.
Unless there's some existing way to specify a FREEZE option in the FDW API
(I assume there isn't), I agree with this.
> I was also looking at why we block a parent from COPY FREEZE[1], but
> the comments do not convince me this is a good idea. I think there
> are good cases to allow this considering there is a common use case in
> which a single
> COPY command can load a large amount of data, making the overhead to check the
> partitions worth the value of the FREEZE optimization. I will probably
> start a separate thread for this.
Commit 5c9a551 and its thread [0] appear to have some additional details
about this.
[0] https://postgr.es/m/CAKJS1f9BbJ%2BFY3TbdCiap3qXHTFOiwtays9s36-oQkkM9_R5bg%40mail.gmail.com
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-02-03 21:05:44 | Re: Prevent COPY FREEZE on Foreign tables |
| Previous Message | Jeff Davis | 2025-02-03 20:45:24 | injection points for hash aggregation |