Re: tablecmds.c/MergeAttributes() cleanup

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tablecmds.c/MergeAttributes() cleanup
Date: 2023-08-30 14:22:03
Message-ID: fef26864-4477-90ec-1ceb-b4189c4cf5c6@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 29.08.23 19:45, Nathan Bossart wrote:
> On Tue, Aug 29, 2023 at 10:43:39AM +0200, Peter Eisentraut wrote:
>> I have committed a few more patches from this series that were already
>> agreed upon. The remaining ones are rebased and reordered a bit, attached.
>
> My compiler is complaining about 1fa9241b:
>
> ../postgresql/src/backend/commands/sequence.c: In function ‘DefineSequence’:
> ../postgresql/src/backend/commands/sequence.c:196:21: error: ‘coldef’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 196 | stmt->tableElts = lappend(stmt->tableElts, coldef);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> This went away when I added a default case that ERROR'd or initialized
> coldef to NULL.

fixed

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-08-30 14:27:55 Re: pg_stat_get_backend_subxact() and backend IDs?
Previous Message David Steele 2023-08-30 14:07:24 Re: New compiler warning