| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: tablecmds.c/MergeAttributes() cleanup |
| Date: | 2023-08-29 17:45:21 |
| Message-ID: | 20230829174521.GA2147567@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 29, 2023 at 10:43:39AM +0200, Peter Eisentraut wrote:
> I have committed a few more patches from this series that were already
> agreed upon. The remaining ones are rebased and reordered a bit, attached.
My compiler is complaining about 1fa9241b:
../postgresql/src/backend/commands/sequence.c: In function ‘DefineSequence’:
../postgresql/src/backend/commands/sequence.c:196:21: error: ‘coldef’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
196 | stmt->tableElts = lappend(stmt->tableElts, coldef);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This went away when I added a default case that ERROR'd or initialized
coldef to NULL.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-08-29 18:44:02 | Re: tablecmds.c/MergeAttributes() cleanup |
| Previous Message | Alvaro Herrera | 2023-08-29 17:28:28 | Re: Strange presentaion related to inheritance in \d+ |