| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Tender Wang <tndrwang(at)gmail(dot)com>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Remove a unnecessary backslash in CopyFrom |
| Date: | 2024-11-12 03:31:14 |
| Message-ID: | fda2a4e5-ad12-4648-9eb4-3dd2fd904ab6@oss.nttdata.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/11/12 11:58, Tender Wang wrote:
>
>
> Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp <mailto:nagata(at)sraoss(dot)co(dot)jp>> 于2024年11月12日周二 10:46写道：
>
> Hi,
>
> I found a unnecessary backslash in CopyFrom().
>
> if (cstate->opts.reject_limit > 0 && \
> cstate->num_errors > cstate->opts.reject_limit)
>
> It can be removed because this is not in a macro.
> I've attached a patch.
>
>
> Yeah, agree. The patch LGTM.
Thanks for the report and patch! This is a mistake in commit 4ac2a9bece.
I'll commit the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-11-12 03:41:19 | Re: Add parallel columns for seq scan and index scan on pg_stat_all_tables and _indexes |
| Previous Message | Michael Paquier | 2024-11-12 03:28:53 | Re: define pg_structiszero(addr, s, r) |