From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Tender Wang <tndrwang(at)gmail(dot)com>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Remove a unnecessary backslash in CopyFrom |
Date: | 2024-11-15 17:08:43 |
Message-ID: | 8de34cea-e6a0-40d7-a1f4-b8886fb5a3d1@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2024/11/12 12:31, Fujii Masao wrote:
>
>
> On 2024/11/12 11:58, Tender Wang wrote:
>>
>>
>> Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp <mailto:nagata(at)sraoss(dot)co(dot)jp>> 于2024年11月12日周二 10:46写道:
>>
>> Hi,
>>
>> I found a unnecessary backslash in CopyFrom().
>>
>> if (cstate->opts.reject_limit > 0 && \
>> cstate->num_errors > cstate->opts.reject_limit)
>>
>> It can be removed because this is not in a macro.
>> I've attached a patch.
>>
>>
>> Yeah, agree. The patch LGTM.
>
> Thanks for the report and patch! This is a mistake in commit 4ac2a9bece.
> I'll commit the patch.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | Dean Rasheed | 2024-11-15 17:26:08 | Re: psql: Add leakproof field to \dAo+ meta-command results |
Previous Message | Peter Geoghegan | 2024-11-15 16:33:37 | nbtree VACUUM's REDO routine doesn't clear page's VACUUM cycle ID |