| From: | Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, zuming(dot)jiang(at)inf(dot)ethz(dot)ch, pgsql-bugs(at)lists(dot)postgresql(dot)org, Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
| Subject: | Re: BUG #18170: Unexpected error: no relation entry for relid 3 |
| Date: | 2023-10-30 02:47:32 |
| Message-ID: | fc183714-a61c-4de7-97e0-b1c376923aef@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 30/10/2023 09:24, Richard Guo wrote:
>
> On Sun, Oct 29, 2023 at 11:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>
> Alexander Korotkov <aekorotkov(at)gmail(dot)com
> <mailto:aekorotkov(at)gmail(dot)com>> writes:
> > I made some beautification of the patch by Andrei. I also
> removed the
> > part which changes the target list for estimate_num_groups(). Any
> > objections to pushing this?
>
> It seems moderately likely that this will break as much as it fixes.
>
> I've not studied the original patch enough to understand why you need
> to be playing strange games with tree mutation rules, but I suspect
> that this is band-aiding over some rather fundamentally bad code.
>
>
> I also have some concerns about this patch. It requires that
> root->parse remains unchanged during the whole subquery_planner() in
> order to work, which is an implicit constraint we did not have before.
It is not about unchanged; it is about referencing the same query at the
parent and child query blocks. Am I missing something?
--
regards,
Andrei Lepikhov
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-10-30 06:24:01 | Re: BUG #18170: Unexpected error: no relation entry for relid 3 |
| Previous Message | Andrei Lepikhov | 2023-10-30 02:43:09 | Re: BUG #18170: Unexpected error: no relation entry for relid 3 |