From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Vik Fearing <vik(at)postgresfriends(dot)org>, zuming(dot)jiang(at)inf(dot)ethz(dot)ch, pgsql-bugs(at)lists(dot)postgresql(dot)org, Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
Subject: | Re: BUG #18170: Unexpected error: no relation entry for relid 3 |
Date: | 2023-10-30 02:24:11 |
Message-ID: | CAMbWs489RP3CFKwtWoG2m=qD5byfS_9_13yVU5wyknDTb3GToQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Sun, Oct 29, 2023 at 11:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> > I made some beautification of the patch by Andrei. I also removed the
> > part which changes the target list for estimate_num_groups(). Any
> > objections to pushing this?
>
> It seems moderately likely that this will break as much as it fixes.
>
> I've not studied the original patch enough to understand why you need
> to be playing strange games with tree mutation rules, but I suspect
> that this is band-aiding over some rather fundamentally bad code.
I also have some concerns about this patch. It requires that
root->parse remains unchanged during the whole subquery_planner() in
order to work, which is an implicit constraint we did not have before.
Thanks
Richard
From | Date | Subject | |
---|---|---|---|
Next Message | Andrei Lepikhov | 2023-10-30 02:43:09 | Re: BUG #18170: Unexpected error: no relation entry for relid 3 |
Previous Message | Richard Guo | 2023-10-30 02:01:02 | Re: BUG #18170: Unexpected error: no relation entry for relid 3 |