Re: Set appropriate processing mode for auxiliary processes.

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Xing Guo <higuoxing(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Set appropriate processing mode for auxiliary processes.
Date: 2024-05-09 14:13:14
Message-ID: f8b36c59-3f5b-49c7-a063-c6cdf71709f6@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09/05/2024 16:12, Xing Guo wrote:
> Hi hackers,
>
> After several refactoring iterations, auxiliary processes are no
> longer initialized from the bootstrapper. I think using the
> InitProcessing mode for initializing auxiliary processes is more
> appropriate.

At first I was sure this was introduced by my refactorings in v17, but
in fact it's been like this forever. I agree that InitProcessing makes
much more sense. The ProcessingMode variable is initialized to
InitProcessing, so I think we can simply remove that line from
AuxiliaryProcessMainCommon(). There are existing
"SetProcessingMode(InitProcessing)" calls in other Main functions too
(AutoVacLauncherMain, BackgroundWorkerMain, etc.), and I think those can
also be removed.

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2024-05-09 14:17:03 Re: First draft of PG 17 release notes
Previous Message David G. Johnston 2024-05-09 13:55:27 Re: request for database identifier in the startup packet