From: | Xing Guo <higuoxing(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Set appropriate processing mode for auxiliary processes. |
Date: | 2024-05-09 14:55:57 |
Message-ID: | CACpMh+C6zPQ5eEPOGpMtqEdtmTueviKCzuGjp596dhmPT-pBuQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 9, 2024 at 10:13 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 09/05/2024 16:12, Xing Guo wrote:
> > Hi hackers,
> >
> > After several refactoring iterations, auxiliary processes are no
> > longer initialized from the bootstrapper. I think using the
> > InitProcessing mode for initializing auxiliary processes is more
> > appropriate.
>
> At first I was sure this was introduced by my refactorings in v17, but
> in fact it's been like this forever. I agree that InitProcessing makes
> much more sense. The ProcessingMode variable is initialized to
> InitProcessing, so I think we can simply remove that line from
> AuxiliaryProcessMainCommon(). There are existing
> "SetProcessingMode(InitProcessing)" calls in other Main functions too
> (AutoVacLauncherMain, BackgroundWorkerMain, etc.), and I think those can
> also be removed.
Good catch! I agree with you.
Best Regards,
Xing.
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Remove-redundant-SetProcessingMode-InitProcessing.patch | text/x-patch | 3.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2024-05-09 14:58:56 | Re: New GUC autovacuum_max_threshold ? |
Previous Message | Bruce Momjian | 2024-05-09 14:51:38 | Re: First draft of PG 17 release notes |