Re: Lack of urgency in 8.3 reviewing

From: "Guido Barosio" <gbarosio(at)gmail(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Lack of urgency in 8.3 reviewing
Date: 2007-05-16 18:09:39
Message-ID: f7f6b4c70705161109p85d902btf991f3db266fd921@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

What about a mentoring schema in order to push up the gap that
represents catching up with cases like the one Andrew posted?

By the way, being a patch reviewer doesn't represents also to be able
to find out potential problems in the code, which may have nothing to
do with the patch functionality?

g.-

On 5/16/07, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Andrew Dunstan wrote:
> >
> >
> > Bruce Momjian wrote:
> > > In talking to people who are assigned to review patches or could review
> > > patches, I often get the reply, "Oh, yea, I need to do that".
> > >
> > > Folks, we are six weeks into feature freeze and have made slim progress
> > > on getting patches reviewed and applied. As I stated earlier, we are
> > > now looking at August/September for beta, but that might be pushed back
> > > even later if we don't get more progress.
> > >
> > > It seems there is a lot of reliance on Tom to get the patches applied,
> > > but I don't think that is fair or reasonable. I think we need more
> > > urgency on the part of everyone to make faster progress. Patch
> > > reviewers and committers need to take more initiative to get things done
> > > rather than wait for some external force to prompt them.
> > >
> > >
> >
> > I at least feel uncomfortable about reviewing code that deals with areas
> > I have not touched much, and where I feel the author probably knows a
> > lot more than me. The chance of my catching errors/problems in such a
> > case is much lower.
>
> Yep, that is part of our problem, but even items people have already
> said they _can_ review have shown little progress.
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
> EnterpriseDB http://www.enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq
>

--
Guido Barosio
-----------------------
http://www.globant.com
guido(dot)barosio(at)globant(dot)com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ron Mayer 2007-05-16 18:17:34 Re: Not ready for 8.3
Previous Message Stefan Kaltenbrunner 2007-05-16 18:06:26 Re: Lack of urgency in 8.3 reviewing