Re: pgsql: Incorporate strerror_r() into src/port/snprintf.c, too.

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Incorporate strerror_r() into src/port/snprintf.c, too.
Date: 2018-09-26 18:04:39
Message-ID: f67b5008-9f01-057f-2bff-558cb53af851@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 26/09/2018 18:36, Tom Lane wrote:
> Incorporate strerror_r() into src/port/snprintf.c, too.
>
> This provides the features that used to exist in useful_strerror()
> for users of strerror_r(), too. Also, standardize on the GNU convention
> that strerror_r returns a char pointer that may not be NULL.

Somehow, this is not working for me:

Undefined symbols for architecture x86_64:
"_libintl_gettext", referenced from:
_pg_strerror_r in strerror.o
ld: symbol(s) not found for architecture x86_64
collect2: error: ld returned 1 exit status
make[4]: *** [../../../../src/Makefile.shlib:303: libpgtypes.3.12.dylib]
Error 1

It works if I don't use --enable-nls.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2018-09-26 18:53:13 pgsql: Recurse to sequences on ownership change for all relkinds
Previous Message Tom Lane 2018-09-26 17:32:03 pgsql: Implement %m in src/port/snprintf.c, and teach elog.c to rely on