pgsql: Incorporate strerror_r() into src/port/snprintf.c, too.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Incorporate strerror_r() into src/port/snprintf.c, too.
Date: 2018-09-26 16:36:03
Message-ID: E1g5CnD-0004v1-Rc@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Incorporate strerror_r() into src/port/snprintf.c, too.

This provides the features that used to exist in useful_strerror()
for users of strerror_r(), too. Also, standardize on the GNU convention
that strerror_r returns a char pointer that may not be NULL.

I notice that libpq's win32.c contains a variant version of strerror_r
that probably ought to be folded into strerror.c. But lacking a
Windows environment, I should leave that to somebody else.

Discussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/758ce9b7794845f95473c569155d29fcf0e2751b

Modified Files
--------------
src/include/port.h | 7 ++-
src/interfaces/libpq/fe-auth.c | 6 +--
src/interfaces/libpq/fe-connect.c | 18 +++----
src/interfaces/libpq/fe-lobj.c | 14 +++---
src/interfaces/libpq/fe-misc.c | 2 +-
src/interfaces/libpq/fe-secure-openssl.c | 12 ++---
src/interfaces/libpq/fe-secure.c | 4 +-
src/interfaces/libpq/libpq-int.h | 2 +-
src/port/strerror.c | 85 +++++++++++++++++++++++---------
src/port/thread.c | 27 ----------
src/test/thread/thread_test.c | 5 +-
11 files changed, 99 insertions(+), 83 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-09-26 17:14:02 pgsql: Always use our own versions of *printf().
Previous Message Tom Lane 2018-09-26 15:06:53 pgsql: Convert elog.c's useful_strerror() into a globally-used strerror