Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Subject: Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Date: 2024-10-01 13:46:45
Message-ID: f3d69b00-f922-4d2b-bf6d-1b87cc221cb3@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.05.24 12:22, Aleksander Alekseev wrote:
> Hi,
>
>>> Thanks. I see a few pieces of code that use special FOO_NUMBER enum
>>> values instead of a macro. Should we refactor these pieces
>>> accordingly? PFA another patch.
>>
>> I think this is a sensible improvement.
>>
>> But please keep the trailing commas on the last enum items.
>
> Thanks, fixed.

committed

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2024-10-01 13:51:34 Re: Converting README documentation to Markdown
Previous Message Takeshi Ideriha 2024-10-01 13:37:47 Re: BUG #18641: Logical decoding of two-phase commit fails with TOASTed default values