| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS |
| Date: | 2024-05-13 10:22:22 |
| Message-ID: | CAJ7c6TNhRz7o=1LcwpQOb6v_8-Kz7TXKdty2-=bT=VaVevi7PQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> > Thanks. I see a few pieces of code that use special FOO_NUMBER enum
> > values instead of a macro. Should we refactor these pieces
> > accordingly? PFA another patch.
>
> I think this is a sensible improvement.
>
> But please keep the trailing commas on the last enum items.
Thanks, fixed.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Use-macro-to-define-the-number-of-enum-values.patch | application/octet-stream | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-05-13 10:37:31 | Re: Add SPLIT PARTITION/MERGE PARTITIONS commands |
| Previous Message | Peter Eisentraut | 2024-05-13 10:11:11 | Re: SQL:2011 application time |