From: | Andrei Zubkov <zubkov(at)moonset(dot)ru> |
---|---|
To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements |
Date: | 2023-03-22 08:17:00 |
Message-ID: | f3bd928173941acbe7a1d026e5439c9955c3f08f.camel@moonset.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Sergei!
Thank you for your review.
On Tue, 2023-03-21 at 23:18 +0300, Sergei Kornilov wrote:
> -- Don't want this to be available to non-superusers.
> REVOKE ALL ON FUNCTION pg_stat_statements_reset(Oid, Oid, bigint,
> boolean) FROM PUBLIC;
>
> should be added to the upgrade script
Indeed.
> Also, shouldn't we first do:
>
> /* First we have to remove them from the extension */
> ALTER EXTENSION pg_stat_statements DROP VIEW ..
> ALTER EXTENSION pg_stat_statements DROP FUNCTION ..
>
> like in previous upgrade scripts?
It was discussed few messages earlier in this thread. We've decided
that those are unnecessary in upgrade script.
> > + Time at which min/max statistics gathering started for this
> > + statement
>
> I think it would be better to explicitly mention in the documentation
> all 4 fields for which minmax_stats_since displays the time.
Agreed.
New version is attached.
regards, Andrei
Attachment | Content-Type | Size |
---|---|---|
v22-0001-pg_stat_statements-tests-Add-NOT-NULL-checking-of-pg.patch | text/x-patch | 50.2 KB |
v22-0002-pg_stat_statements-Track-statement-entry-timestamp.patch | text/x-patch | 39.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Drouvot, Bertrand | 2023-03-22 08:20:25 | Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry |
Previous Message | shiy.fnst@fujitsu.com | 2023-03-22 08:08:22 | RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL |