Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements

Hello!

The documentation still describes the function pg_stat_statements_reset like this

> By default, this function can only be executed by superusers.

But unfortunately, this part was lost somewhere.

-- Don't want this to be available to non-superusers.
REVOKE ALL ON FUNCTION pg_stat_statements_reset(Oid, Oid, bigint, boolean) FROM PUBLIC;

should be added to the upgrade script

Also, shouldn't we first do:

/* First we have to remove them from the extension */
ALTER EXTENSION pg_stat_statements DROP VIEW ..
ALTER EXTENSION pg_stat_statements DROP FUNCTION ..

like in previous upgrade scripts?

> + Time at which min/max statistics gathering started for this
> + statement

I think it would be better to explicitly mention in the documentation all 4 fields for which minmax_stats_since displays the time.

regards, Sergei