Re: Enable data checksums by default

On 14.10.24 11:28, Peter Eisentraut wrote:
> On 03.10.24 23:13, Nathan Bossart wrote:
>> On Tue, Oct 01, 2024 at 11:15:02AM -0400, Peter Eisentraut wrote:
>>> I have committed 0001 (the new option) and 0004 (the docs tweak).  I
>>> think
>>> there is consensus for the rest, too, but I'll leave it for a few
>>> more days
>>> to think about.  I guess the test failure has to be addressed.
>>
>> Here is a rebased patch with the test fix (for cfbot).  I have made no
>> other changes.
>
> I have committed the test changes (patch 0002).  (I renamed the option
> to no_data_checksums to keep the wording consistent with the initdb
> option.)
>
> Right now, with checksums off by default, this doesn't do much, but you
> can test this like
>
>     PG_TEST_INITDB_EXTRA_OPTS=--data-checksums meson test ...
>
> and everything will pass.  To make that work, I had to adjust the order
> of how the initdb options are assembled in Cluster.pm a bit.
>
> I will work on the patch that flips the default next.

The patch that flips the default has been committed.

I also started a PG18 open items page and made a note that we follow up
on the upgrade experience, as was discussed in this thread.

https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items