| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Enable data checksums by default |
| Date: | 2024-10-14 09:28:41 |
| Message-ID: | 6f5263b0-6909-4192-87f0-9e140b9a72ab@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03.10.24 23:13, Nathan Bossart wrote:
> On Tue, Oct 01, 2024 at 11:15:02AM -0400, Peter Eisentraut wrote:
>> I have committed 0001 (the new option) and 0004 (the docs tweak). I think
>> there is consensus for the rest, too, but I'll leave it for a few more days
>> to think about. I guess the test failure has to be addressed.
>
> Here is a rebased patch with the test fix (for cfbot). I have made no
> other changes.
I have committed the test changes (patch 0002). (I renamed the option
to no_data_checksums to keep the wording consistent with the initdb option.)
Right now, with checksums off by default, this doesn't do much, but you
can test this like
PG_TEST_INITDB_EXTRA_OPTS=--data-checksums meson test ...
and everything will pass. To make that work, I had to adjust the order
of how the initdb options are assembled in Cluster.pm a bit.
I will work on the patch that flips the default next.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nitin Motiani | 2024-10-14 09:45:43 | Re: Inval reliability, especially for inplace updates |
| Previous Message | Alexander Kuznetsov | 2024-10-14 09:25:50 | Check for tuplestorestate nullness before dereferencing |