| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: downgrade some aclchk.c errors to internal |
| Date: | 2024-12-20 14:03:17 |
| Message-ID: | ef5624c6-d09a-4cde-92ac-331264b21f8e@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.12.24 12:47, Peter Eisentraut wrote:
> In aclchk.c, there are a few error messages that use ereport() but it
> seems like they should be internal error messages. Moreover, they are
> using get_object_class_descr(), which is only meant for internal errors.
> (For example, it does not have translation support.) I dug through
> this and it seems like these errors are indeed not or no longer user-
> facing, so we can downgrade them to internal. See commit messages in
> the attached patches for further explanations.
There was a mistake in the second patch, I had missed some other callers
that I have fixed up here. Amended patch set attached.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Downgrade-errors-in-object_ownercheck-to-internal.patch | text/plain | 3.0 KB |
| v2-0002-Downgrade-error-in-object_aclmask_ext-to-internal.patch | text/plain | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-12-20 14:29:40 | Re: pure parsers and reentrant scanners |
| Previous Message | Pavel Stehule | 2024-12-20 12:53:20 | Re: proposal: schema variables |