| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | downgrade some aclchk.c errors to internal |
| Date: | 2024-12-20 11:47:31 |
| Message-ID: | da2f8942-be6d-48d0-ac1c-a053370a6b1f@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
In aclchk.c, there are a few error messages that use ereport() but it
seems like they should be internal error messages. Moreover, they are
using get_object_class_descr(), which is only meant for internal errors.
(For example, it does not have translation support.) I dug through
this and it seems like these errors are indeed not or no longer
user-facing, so we can downgrade them to internal. See commit messages
in the attached patches for further explanations.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Downgrade-errors-in-object_ownercheck-to-internal.patch | text/plain | 3.0 KB |
| 0002-Downgrade-error-in-object_aclmask_ext-to-internal.patch | text/plain | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2024-12-20 12:25:41 | Re: FileFallocate misbehaving on XFS |
| Previous Message | Amit Langote | 2024-12-20 11:41:25 | Some ExecSeqScan optimizations |