Re: [PATCH] Fix build on MINGW on ARM64

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Lars Kanis <lars(at)greiz-reinsdorf(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix build on MINGW on ARM64
Date: 2025-04-07 15:21:29
Message-ID: ecf39320-7b89-4b2a-876a-7e568c1b198b@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2025-04-07 Mo 11:05 AM, Andrew Dunstan wrote:
>
> On 2025-04-07 Mo 12:58 AM, Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>> On 2025-04-01 Tu 11:15 AM, Andrew Dunstan wrote:
>>>> On 2025-04-01 Tu 8:47 AM, vignesh C wrote:
>>>>> There is an existing CF entry for this at [1]. If no one picks this
>>>>> till the end of this CF, we can move it to next CF.
>>>>> [1] - https://commitfest.postgresql.org/patch/5610/
>>>> Somehow I missed that. OK, looks good, will commit shortly.
>>> Done
>> fairywren has been failing rather horribly since this went in [1].
>> It's not certain of course that this commit broke it and not one
>> of the other ones that first appeared in that build -- but none
>> of the other ones look plausibly related.
>>
>>             regards, tom lane
>>
>> [1]
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2025-04-02%2007%3A06%3A04
>
>
>
> Yes, that was indeed the problem. I have reverted the patch.
>
>
>

Lars,

I have marked the CF entry as Returned with Feedback - you can submit
again, but will need to show that this does not cause breakage on x86_64
using any msys2 toolchain.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-04-07 15:27:19 Re: Logging which local address was connected to in log_line_prefix
Previous Message Tomas Vondra 2025-04-07 15:11:11 Re: Draft for basic NUMA observability