Re: Logging which local address was connected to in log_line_prefix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Cc: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, david(at)pgmasters(dot)net, Peter Eisentraut <peter(at)eisentraut(dot)org>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Logging which local address was connected to in log_line_prefix
Date: 2025-04-07 15:27:19
Message-ID: 3463767.1744039639@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greg Sabino Mullane <htamfids(at)gmail(dot)com> writes:
> On Sun, Apr 6, 2025 at 6:01 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> 1. Ignore the inconsistency, commit 0004 as-is.
>>
>> 2. Change the output to be an empty string in background processes.
>> This is consistent, but it goes against our upthread feeling that
>> "[none]" would avoid confusion.

> I lean for #1. Yes, there is some inconsistency, but it feels like the
> right thing to do, and this is a feature I suspect not many people will use
> anyway.

Hearing no other comments, I pushed 0004 as-is. It's trivial enough
to replace "[none]" with "" if somebody makes the case for that.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-04-07 15:29:53 Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.
Previous Message Andrew Dunstan 2025-04-07 15:21:29 Re: [PATCH] Fix build on MINGW on ARM64