| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres_fdw batching vs. (re)creating the tuple slots |
| Date: | 2021-06-09 11:08:36 |
| Message-ID: | ec1c620f-b9ff-26ac-6848-6e39f0a72f6e@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/9/21 12:50 PM, Bharath Rupireddy wrote:
> On Wed, Jun 9, 2021 at 4:00 PM Tomas Vondra
> <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>>
>> Hi,
>>
>> Here's a v2 fixing a silly bug with reusing the same variable in two
>> nested loops (worked for simple postgres_fdw cases, but "make check"
>> failed).
>
> I applied these patches and ran make check in postgres_fdw contrib
> module, I saw a server crash. Is it the same failure you were saying
> above?
>
Nope, that was causing infinite loop. This is jut a silly mistake on my
side - I forgot to replace the i/j variable inside the loop. Here's v3.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-create-copy-of-a-descriptor-for-batching-v3.patch | text/x-patch | 1.5 KB |
| 0002-initialize-slots-only-once-for-batching-v3.patch | text/x-patch | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-06-09 11:20:38 | Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command |
| Previous Message | Heikki Linnakangas | 2021-06-09 11:02:02 | Re: speed up verifying UTF-8 |