Re: postgres_fdw batching vs. (re)creating the tuple slots

On Wed, Jun 9, 2021 at 4:38 PM Tomas Vondra
<tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>
> On 6/9/21 12:50 PM, Bharath Rupireddy wrote:
> > On Wed, Jun 9, 2021 at 4:00 PM Tomas Vondra
> > <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
> >>
> >> Hi,
> >>
> >> Here's a v2 fixing a silly bug with reusing the same variable in two
> >> nested loops (worked for simple postgres_fdw cases, but "make check"
> >> failed).
> >
> > I applied these patches and ran make check in postgres_fdw contrib
> > module, I saw a server crash. Is it the same failure you were saying
> > above?
> >
>
> Nope, that was causing infinite loop. This is jut a silly mistake on my
> side - I forgot to replace the i/j variable inside the loop. Here's v3.

Thanks. The postgres_fdw regression test execution time is not
increased too much with the patches even with the test case added by
the below commit. With and without the patches attached in this
thread, the execution times are 5 sec and 17 sec respectively. So,
essentially these patches are reducing the execution time for the test
case added by the below commit.

commit cb92703384e2bb3fa0a690e5dbb95ad333c2b44c
Author: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
Date: Tue Jun 8 20:22:18 2021 +0200

Adjust batch size in postgres_fdw to not use too many parameters

With Regards,
Bharath Rupireddy.