| From: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io> |
| Subject: | Re: SQLFunctionCache and generic plans |
| Date: | 2025-04-03 05:38:18 |
| Message-ID: | e9a2104f9efabf678ddc9c0a78d62189@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane писал(а) 2025-04-02 21:09:
> I wrote:
>> Anyway, I feel pretty good about this patch now and am quite content
>> to stop here for PG 18.
>
> Since feature freeze is fast approaching, I did a tiny bit more
> cosmetic work on this patchset and then pushed it. (There's still
> plenty of time for adjustments if you have further comments.)
>
> Thanks for working on this! This is something I've wanted to see
> done ever since we invented plancache.
>
> regards, tom lane
Hi. I've looked through the latest patch series, but didn't have much
time to examine them thoroughly.
Haven't found any issue so far. From cosmetic things I've noticed - I
would set func->pcontext to NULL in sql_delete_callback() to avoid
dangling pointer if we error out early (but it seems only to be a matter
of taste).
--
Best regards,
Alexander Pyhalov,
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-04-03 05:46:25 | Re: Fix 035_standby_logical_decoding.pl race conditions |
| Previous Message | Masahiko Sawada | 2025-04-03 05:37:59 | Re: Fix slot synchronization with two_phase decoding enabled |