Re: Logging parallel worker draught

From: Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
Subject: Re: Logging parallel worker draught
Date: 2025-01-29 16:41:45
Message-ID: e8df9573-b05f-4e8a-ab20-af134b469574@dalibo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/29/25 12:41 AM, Sami Imseih wrote:
> There will both be an INFO ( existing behavior ) and LOG ( new behavior ).
> This seems wrong to me and there should only really be one
> mechanism to log parallel workers for utility statements.
> Others may have different opinions.

In the use case you describe, I agree that the VERBOSE option is more
suited for the job. But it's not the use case I had in mind for this
guc.

The "story" I have in mind is: I need to audit an instance I know
nothing about. I ask the client to adapt the logging parameters for
pgbadger (including this one), collect the logs and generate a report
for the said period to have a broad overview of what is happenning.

I attached patches that implemented both your suggestions (I regrouped
all the utilities together).

Thank you !

--
Benoit Lobréau
Consultant
http://dalibo.com

Attachment Content-Type Size
V7_0001-Add-a-guc-for-parallel-worker-logging.patch text/x-patch 6.8 KB
V7_0002-Setup-counters-for-parallel-vacuums.patch text/x-patch 1.6 KB
V7_0003-Implements-logging-for-parallel-worker-usage-in-util.patch text/x-patch 2.3 KB
V7_0004-Implements-logging-for-parallel-worker-usage-in-quer.patch text/x-patch 1.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-01-29 16:50:19 Re: Windows CFBot is broken because ecpg dec_test.c error
Previous Message Melanie Plageman 2025-01-29 16:34:55 Re: Eagerly scan all-visible pages to amortize aggressive vacuum