Re: Logging parallel worker draught

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
Subject: Re: Logging parallel worker draught
Date: 2025-02-03 05:36:52
Message-ID: CAA5RZ0tHb_hpq472oMj6S8F5kgXiOE-mV9QYSJOjn4g+CvZXmA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> The "story" I have in mind is: I need to audit an instance I know
> nothing about. I ask the client to adapt the logging parameters for
> pgbadger (including this one), collect the logs and generate a report
> for the said period to have a broad overview of what is happenning.

Let's see if anyone has a different opinion.

As far as the current set of patches, I had some other changes that
I missed earlier; indentation to the calls in LogParallelWorkersIfNeeded
and comment for the LogParallelWorkersIfNeeded function. I also re-worked the
setup of the GUC as it was not setup the same way as other
GUCs with an options list. I ended up just making those changes
in v8.

Besides that, I think this is ready for committer.

Regards,

Sami

Attachment Content-Type Size
v8-0002-Setup-counters-for-parallel-vacuums.patch application/octet-stream 1.6 KB
v8-0001-Add-a-guc-for-parallel-worker-logging.patch application/octet-stream 7.0 KB
v8-0003-Implements-logging-for-parallel-worker-usage-in-u.patch application/octet-stream 2.3 KB
v8-0004-Implements-logging-for-parallel-worker-usage-in-q.patch application/octet-stream 1.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2025-02-03 05:43:31 Re: Logical Replication of sequences
Previous Message Amul Sul 2025-02-03 05:30:00 Re: NOT ENFORCED constraint feature