| From: | "Daniel Verite" <daniel(at)manitou-mail(dot)org> |
|---|---|
| To: | "Craig Ringer" <craig(at)2ndquadrant(dot)com> |
| Cc: | "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com>,"Dmitry Igrishin" <dmitigr(at)gmail(dot)com>,"Andres Freund" <andres(at)anarazel(dot)de>,"PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>,"Manuel Kniep" <m(dot)kniep(at)web(dot)de>,"fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: PATCH: Batch/pipelining support for libpq |
| Date: | 2016-09-06 08:10:08 |
| Message-ID: | e8caca78-b3ee-436a-a5e9-d2f971a34cbf@mm |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Craig Ringer wrote:
> Updated patch attached.
Please find attached a couple fixes for typos I've came across in
the doc part.
Also it appears that PQqueriesInBatch() doesn't work as documented.
It says:
"Returns the number of queries still in the queue for this batch"
but in fact it's implemented as a boolean:
+/* PQqueriesInBatch
+ * Return true if there are queries currently pending in batch mode
+ */+int
+PQqueriesInBatch(PGconn *conn)
+{
+ if (!PQisInBatchMode(conn))
+ return false;
+
+ return conn->cmd_queue_head != NULL;
+}
However, is this function really needed? It doesn't seem essential to
the API. You don't call it in the test program either.
Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite
| Attachment | Content-Type | Size |
|---|---|---|
| diff-typos.txt | text/plain | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2016-09-06 08:12:18 | Re: Proposal for changes to recovery.conf API |
| Previous Message | Amit Langote | 2016-09-06 08:07:33 | Re: Declarative partitioning - another take |