| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Daniel Verite <daniel(at)manitou-mail(dot)org> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Dmitry Igrishin <dmitigr(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Manuel Kniep <m(dot)kniep(at)web(dot)de>, "fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: PATCH: Batch/pipelining support for libpq |
| Date: | 2016-09-06 11:01:50 |
| Message-ID: | CAMsr+YG5R56PMAAt=AtSAab-5U0Kb0Km+GJRX01atM=fpqc+wQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6 September 2016 at 16:10, Daniel Verite <daniel(at)manitou-mail(dot)org> wrote:
> Craig Ringer wrote:
>
>> Updated patch attached.
>
> Please find attached a couple fixes for typos I've came across in
> the doc part.
Thanks, will apply and post a rebased patch soon, or if someone picks
this up in the mean time they can apply your diff on top of the patch.
> Also it appears that PQqueriesInBatch() doesn't work as documented.
> It says:
> "Returns the number of queries still in the queue for this batch"
> but in fact it's implemented as a boolean:
Whoops. Will fix.
I think the function is useful and necessary. There's no reason not to
expose that, but also it's good for when your query dispatch isn't as
tightly coupled to your query handling as in the example, so your app
might need to keep processing until it sees the end of queued results.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rajkumar Raghuwanshi | 2016-09-06 11:15:29 | Re: Declarative partitioning - another take |
| Previous Message | Simon Riggs | 2016-09-06 10:30:57 | Bug in VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL |