| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Data type correction in pgstat_report_replslot function parameters |
| Date: | 2021-04-01 17:48:34 |
| Message-ID: | e80503a5-c9ef-469f-0e63-25a4b193165e@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/04/02 2:18, Jeevan Ladhe wrote:
>
>
> On Thu, Apr 1, 2021 at 10:20 PM vignesh C <vignesh21(at)gmail(dot)com <mailto:vignesh21(at)gmail(dot)com>> wrote:
>
> Hi,
>
> While I was reviewing replication slot statistics code, I found one
> issue in the data type used for pgstat_report_replslot function
> parameters. We pass int64 variables to the function but the function
> prototype uses int type. I I felt the function parameters should be
> int64. Attached patch fixes the same.
Isn't it better to use PgStat_Counter instead of int64?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-04-01 17:56:42 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Previous Message | Tom Lane | 2021-04-01 17:46:37 | Re: libpq debug log |