| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Data type correction in pgstat_report_replslot function parameters |
| Date: | 2021-04-02 02:20:48 |
| Message-ID: | CALDaNm27C8ODptcoHu_GB=qPaT=TpXHyuZJw6dMoQsUN00Vq+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 1, 2021 at 11:18 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
>
>
> On 2021/04/02 2:18, Jeevan Ladhe wrote:
> >
> >
> > On Thu, Apr 1, 2021 at 10:20 PM vignesh C <vignesh21(at)gmail(dot)com <mailto:vignesh21(at)gmail(dot)com>> wrote:
> >
> > Hi,
> >
> > While I was reviewing replication slot statistics code, I found one
> > issue in the data type used for pgstat_report_replslot function
> > parameters. We pass int64 variables to the function but the function
> > prototype uses int type. I I felt the function parameters should be
> > int64. Attached patch fixes the same.
>
> Isn't it better to use PgStat_Counter instead of int64?
>
Thanks for your comment, the updated patch contains the changes for it.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Data-type-correction-in-pgstat_report_replslot.patch | text/x-patch | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 'alvherre@alvh.no-ip.org' | 2021-04-02 02:30:10 | Re: libpq debug log |
| Previous Message | David Rowley | 2021-04-02 01:15:40 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |