| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alex Wang <alex(dot)wang(at)enterprisedb(dot)com>, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Subject: | Re: Index AM API cleanup |
| Date: | 2025-01-15 22:14:24 |
| Message-ID: | e7fa5fac-33cf-44ae-baf8-04ebb1d92eac@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15.01.25 22:15, Nathan Bossart wrote:
> On Wed, Jan 15, 2025 at 03:31:12PM +0100, Peter Eisentraut wrote:
>> On 04.12.24 15:49, Peter Eisentraut wrote:
>>> Here is a patch set in that direction. It renames RowCompareType to
>>> CompareType and updates the surrounding commentary a bit. And then I'm
>>> changing the gist strategy mapping to use the CompareType values instead
>>> of the RT* strategy numbers. Seeing this now, I like this a lot better
>>> than what we have now, because it makes it clearer in the API and the
>>> code what is a real strategy number and what's a different kind of
>>> thing. (This isn't entirely the above-mentioned integration of the gist
>>> support into your patch set yet, but it's a meaningful part of it.)
>>
>> I have committed these, and I'll continue working my way through this patch
>> set now.
>
> cfbot's cpluspluscheck step seems to dislike the new CompareType enum
> declaraction [0]. IIUC that isn't valid in C++.
Fixed, thanks.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-01-15 22:20:58 | Re: Use Python "Limited API" in PL/Python |
| Previous Message | Thomas Munro | 2025-01-15 22:07:41 | Re: convert libpgport's pqsignal() to a void function |