| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alex Wang <alex(dot)wang(at)enterprisedb(dot)com>, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Subject: | Re: Index AM API cleanup |
| Date: | 2025-01-15 21:15:51 |
| Message-ID: | Z4glhxuoS7wQcpHL@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 15, 2025 at 03:31:12PM +0100, Peter Eisentraut wrote:
> On 04.12.24 15:49, Peter Eisentraut wrote:
>> Here is a patch set in that direction. It renames RowCompareType to
>> CompareType and updates the surrounding commentary a bit. And then I'm
>> changing the gist strategy mapping to use the CompareType values instead
>> of the RT* strategy numbers. Seeing this now, I like this a lot better
>> than what we have now, because it makes it clearer in the API and the
>> code what is a real strategy number and what's a different kind of
>> thing. (This isn't entirely the above-mentioned integration of the gist
>> support into your patch set yet, but it's a meaningful part of it.)
>
> I have committed these, and I'll continue working my way through this patch
> set now.
cfbot's cpluspluscheck step seems to dislike the new CompareType enum
declaraction [0]. IIUC that isn't valid in C++.
[0] https://api.cirrus-ci.com/v1/task/4946960681009152/logs/headers_cpluspluscheck.log
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2025-01-15 21:21:34 | Re: Unicode full case mapping: PG_UNICODE_FAST, and standard-compliant UCS_BASIC |
| Previous Message | Jim Jones | 2025-01-15 21:05:41 | Re: XMLDocument (SQL/XML X030) |