| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Variable renaming in dbcommands.c |
| Date: | 2024-08-15 05:14:26 |
| Message-ID: | e2d87e67-e889-4768-b07e-181aef299086@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.08.24 09:43, Daniel Gustafsson wrote:
>> On 9 Aug 2024, at 09:21, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
>> In dbcommands.c function createdb(), there are several sets of very similar local variable names, such as "downer" and "dbowner", which is very confusing and error-prone. The first set are the DefElem nodes from the parser, the second set are the local variables with the values extracted from them. This patch renames the former to "ownerEl" and so on, similar to collationcmds.c and typecmds.c, to improve clarity.
>
> No objections, patch LGTM.
committed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2024-08-15 05:55:15 | Re: proposal: schema variables |
| Previous Message | Joel Jacobson | 2024-08-15 04:19:36 | Re: [PATCH] Add get_bytes() and set_bytes() functions |