Re: Variable renaming in dbcommands.c

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Variable renaming in dbcommands.c
Date: 2024-08-09 07:43:37
Message-ID: 27317B09-4813-4D36-B704-57BDE2786CA9@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 9 Aug 2024, at 09:21, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:

> In dbcommands.c function createdb(), there are several sets of very similar local variable names, such as "downer" and "dbowner", which is very confusing and error-prone. The first set are the DefElem nodes from the parser, the second set are the local variables with the values extracted from them. This patch renames the former to "ownerEl" and so on, similar to collationcmds.c and typecmds.c, to improve clarity.

No objections, patch LGTM.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2024-08-09 08:16:28 Improve error message for ICU libraries if pkg-config is absent
Previous Message Peter Eisentraut 2024-08-09 07:21:24 Variable renaming in dbcommands.c